bugfix/mingw-timeapi #1345
Open
bugfix/mingw-timeapi #1345
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
|
We already have this code block which includes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Win32 port: fix MinGW build failure caused by timeapi.h
Description
The Win32 simulator port unconditionally includes <timeapi.h>,
which is available when building with MSVC but not consistently
available when building with MinGW-w64 GCC.
This change guards the include using _MSC_VER and relies on
<mmsystem.h> for MinGW builds, restoring build compatibility
without affecting MSVC builds.
Test Steps
Checklist:
Related Issue
Fixes #1344